Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48256 )
Change subject: soc/amd/common/bloc: Code to digest FSP PerformanceLib timestamps ......................................................................
Patch Set 1:
(3 comments)
First pass, need fix the few things I have found so far. Also wondering if this should remain in the AMD common folder or be moved to the Intel FSP folder, does not seem right (unless we rename that folder) but I am open to it
https://review.coreboot.org/c/coreboot/+/48256/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48256/1//COMMIT_MSG@7 PS1, Line 7: soc/amd/common/bloc: Code to digest FSP PerformanceLib timestamps Oops, meant 'block'
https://review.coreboot.org/c/coreboot/+/48256/1/src/drivers/intel/fsp2_0/ha... File src/drivers/intel/fsp2_0/hand_off_block.c:
https://review.coreboot.org/c/coreboot/+/48256/1/src/drivers/intel/fsp2_0/ha... PS1, Line 186: const void *fsp_find_extension_hob_inst_by_guid(const uint8_t *guid, size_t *size, const uint8_t instance_num) gotta clang-format this
https://review.coreboot.org/c/coreboot/+/48256/1/src/drivers/intel/fsp2_0/in... File src/drivers/intel/fsp2_0/include/fsp/util.h:
https://review.coreboot.org/c/coreboot/+/48256/1/src/drivers/intel/fsp2_0/in... PS1, Line 80: const void *fsp_find_extension_hob_inst_by_guid(const uint8_t *guid, size_t *size, const uint8_t instance_num); ditto here