Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32131 )
Change subject: arch/x86/smbios: Add type 7
......................................................................
Patch Set 3:
(3 comments)
Tested on Lenovo T520 (Intel Sandy Bridge). All caches are listed.
https://review.coreboot.org/#/c/32131/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32131/2//COMMIT_MSG@11
PS2, Line 11: SMBIOS 3.1+
Please, why isn't 3. […]
The structure was last updated with 3.1. It didn't change with 3.2.
https://review.coreboot.org/#/c/32131/2/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32131/2/src/arch/x86/smbios.c@687
PS2, Line 687:
Remove the blank line?
Done
https://review.coreboot.org/#/c/32131/2/src/arch/x86/smbios.c@695
PS2, Line 695: the
Remove the article, because it’s not a full sentence, and no article is used in the other descriptio […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32131
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80ed25b8f2c7b425136b2f0c755324a8f5d1636d
Gerrit-Change-Number: 32131
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Sven Schnelle
svens@stackframe.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Comment-Date: Tue, 02 Apr 2019 16:31:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment