Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46687 )
Change subject: mb/google/asurada: Implement enable_requlator and regulator_is_enabled ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46687/1/src/mainboard/google/asurad... File src/mainboard/google/asurada/regulator.c:
https://review.coreboot.org/c/coreboot/+/46687/1/src/mainboard/google/asurad... PS1, Line 114: regualtor regulator
https://review.coreboot.org/c/coreboot/+/46687/1/src/mainboard/google/asurad... PS1, Line 109: if (id >= 0) { : google_chromeec_regulator_enable(id, enable); : return; : } : : printk(BIOS_WARNING, "Invalid regualtor ID: %d\n", regulator); Reverse the order:
if (id < 0) { printk(...); return; }
google_chromeec_regulator_enable(id, enable);
https://review.coreboot.org/c/coreboot/+/46687/1/src/mainboard/google/asurad... PS1, Line 128: Invalid regualtor ID: %d Invalid regulator ID: %d; assuming disabled
https://review.coreboot.org/c/coreboot/+/46687/1/src/mainboard/google/asurad... PS1, Line 122: if (id >= 0) { : uint8_t enabled = 0; : google_chromeec_regulator_is_enabled(id, &enabled); : return enabled; : } : : printk(BIOS_WARNING, "Invalid regualtor ID: %d\n", regulator); : : return 0; Same.