Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34745 )
Change subject: intel/fsp_broadwell_de: Use smm_subregion()
......................................................................
Patch Set 11: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34745/11/src/soc/intel/fsp_broadwel...
File src/soc/intel/fsp_broadwell_de/memmap.c:
https://review.coreboot.org/c/coreboot/+/34745/11/src/soc/intel/fsp_broadwel...
PS11, Line 32: uintptr_t tseg = pci_read_config32(PCI_DEV(0, 0, 0), TSEG_BASE);
tseg is on the VTD devices
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34745
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I986bbe978d3f68693b2d4538ccbcc11cdbd23c6a
Gerrit-Change-Number: 34745
Gerrit-PatchSet: 11
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 22 Aug 2019 07:22:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment