Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34582 )
Change subject: soc/intel/common/block/uart: Update the UART PCI device reference ......................................................................
Patch Set 5: Code-Review+2
(3 comments)
With `const` on all paths now, we could also turn the remaining `DEVTREE_CONST` into `const`. But I don't want to be picky, this is good work.
https://review.coreboot.org/c/coreboot/+/34582/5/src/soc/intel/common/block/... File src/soc/intel/common/block/uart/uart.c:
https://review.coreboot.org/c/coreboot/+/34582/5/src/soc/intel/common/block/... PS5, Line 76: if (!dev) : return; Nit: As `device` is already checked by the caller, and the `pci_devfn_t` shouldn't be 0 anyway, this could be dropped now.
https://review.coreboot.org/c/coreboot/+/34582/5/src/soc/intel/common/block/... PS5, Line 80: pci_write_config32(dev, PCI_BASE_ADDRESS_0, baseaddr); Question for Kyösti, actually: If we'd use the simple version here (pci_s_write_config32()), we wouldn't need the #if above. Would such usage be encouraged? Do we want to keep the simple versions in the long run?
https://review.coreboot.org/c/coreboot/+/34582/5/src/soc/intel/common/block/... PS5, Line 147: return; Nit: This looks odd with the empty line above but none below.