With `const` on all paths now, we could also turn the
remaining `DEVTREE_CONST` into `const`. But I don't want
to be picky, this is good work.
Patch set 5:Code-Review +2
3 comments:
File src/soc/intel/common/block/uart/uart.c:
if (!dev)
return;
Nit: As `device` is already checked by the caller, and the `pci_devfn_t`
shouldn't be 0 anyway, this could be dropped now.
Patch Set #5, Line 80: pci_write_config32(dev, PCI_BASE_ADDRESS_0, baseaddr);
Question for Kyösti, actually: If we'd use the simple version here
(pci_s_write_config32()), we wouldn't need the #if above. Would such
usage be encouraged? Do we want to keep the simple versions in the
long run?
Patch Set #5, Line 147: return;
Nit: This looks odd with the empty line above but none below.
To view, visit change 34582. To unsubscribe, or for help writing mail filters, visit settings.