David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42302 )
Change subject: mb/google/volteer/var/terrador: Update gpio settings and overridetree.cb ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42302/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/terrador/gpio.c:
https://review.coreboot.org/c/coreboot/+/42302/11/src/mainboard/google/volte... PS11, Line 175: /* A12 : SATAXPCIE1 ==> M2_SSD_PEDET */ : PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), : : /* A17 : DDSP_HPDC ==> MEM_CH_SEL */ : PAD_CFG_GPI(GPP_A17, NONE, DEEP), : : /* B11 : PMCALERT# ==> PCH_WP_OD */ : PAD_CFG_GPI_GPIO_DRIVER(GPP_B11, NONE, DEEP), : : /* B15 : GSPI0_CS0# ==> PCH_GSPI0_H1_TPM_CS_L */ : PAD_CFG_NF(GPP_B15, NONE, DEEP, NF1), : : /* B16 : GSPI0_CLK ==> PCH_GSPI0_H1_TPM_CLK */ : PAD_CFG_NF(GPP_B16, NONE, DEEP, NF1), : : /* B17 : GSPI0_MISO ==> PCH_GSPI0_H1_TPM_MISO */ : PAD_CFG_NF(GPP_B17, NONE, DEEP, NF1), : : /* B18 : GSPI0_MOSI ==> PCH_GSPI0_H1_TPM_MOSI_STRAP */ : PAD_CFG_NF(GPP_B18, DN_20K, DEEP, NF1), : : /* C0 : SMBCLK ==> EN_PP3300_WLAN */ : PAD_CFG_GPO(GPP_C0, 1, DEEP), : : /* C21 : UART2_TXD ==> H1_PCH_INT_ODL */ : PAD_CFG_GPI_APIC(GPP_C21, NONE, PLTRST, LEVEL, INVERT), : : /* C22 : UART2_RTS# ==> PCH_FPMCU_BOOT0 */ : PAD_CFG_GPO(GPP_C22, 0, DEEP), : : /* E12 : SPI1_MISO_IO1 ==> PEN_ALERT_ODL */ : PAD_CFG_GPI(GPP_E12, NONE, DEEP), : };
could you group these similarly to the above table? (all GPP_A next to each other, GPP_B, etc. […]
Done