Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Doc/mb/ocp: Add documentation for Tiogapass
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp...
File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp...
PS3, Line 30: Linuxboot binary
It would be nice to move it into its own section, and out of the "Required blobs" section. […]
Makes sense. I added a "Payload" section.
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp...
PS3, Line 38: not verified
Right. Would be nice to test it, if possible.
Yes, we will test it in coming months.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40925
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4c2832d5bd006c572dab035040b4242f8a3d53b
Gerrit-Change-Number: 40925
Gerrit-PatchSet: 4
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 11 May 2020 18:45:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment