build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31123 )
Change subject: WIP: bootmem: add new memory type for BL31
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/#/c/31123/10/src/arch/arm64/include/arch/memlayo...
File src/arch/arm64/include/arch/memlayout.h:
https://review.coreboot.org/#/c/31123/10/src/arch/arm64/include/arch/memlayo...
PS10, Line 40: #define BL31(addr, size) \
Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/#/c/31123/10/src/arch/arm64/include/arch/memlayo...
PS10, Line 40: #define BL31(addr, size) \
macros should not use a trailing semicolon
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31123
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idbd9a7fe4b12af23de1519892936d8d88a000e2c
Gerrit-Change-Number: 31123
Gerrit-PatchSet: 10
Gerrit-Owner: Ting Shen
phoenixshen@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Ting Shen
phoenixshen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 31 Jan 2019 08:55:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment