mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31019 )
Change subject: spi/winbond.c: change protection_granularity_shift for W25Q256* from 16 to 19
......................................................................
Patch Set 1:
Patch Set 1: Code-Review-2
Please read the datasheets.
Sorry I checked the datasheets and haven't been able to find any mention of granularity. Could you please clarify where I should be looking, or at least confirm that W25Q256* are really 16 while W25Q128* are 18 (>16) because it looks strange to me
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31019
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I488d20898fccd1e967334fdd982b31eedf48f412
Gerrit-Change-Number: 31019
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb
mikebdp2@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mikeb mikeb
mikebdp2@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 21 Jan 2019 09:07:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment