Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42677 )
Change subject: soc/intel/tigerlake: Change pmc_set_acpi_mode() run after BS_DEV_INIT
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42677/2/src/soc/intel/tigerlake/pmc...
File src/soc/intel/tigerlake/pmc.c:
https://review.coreboot.org/c/coreboot/+/42677/2/src/soc/intel/tigerlake/pmc...
PS2, Line 166: BOOT_STATE_INIT_ENTRY(BS_DEV_INIT, BS_ON_EXIT, soc_acpi_mode_init, NULL);
If this needs to happen in BS_DEV_INIT phase, then it would be better to add .init ops in pmc_ops below and call pmc_set_acpi_mode() from it. This is different than CNL because Tim enabled the PMC device driver for TGL. So, you can make you of device_operations instead of adding BOOT_STATE_* callbacks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42677
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfff5cc5550f23938343e4d26ef76093bb9cf7c3
Gerrit-Change-Number: 42677
Gerrit-PatchSet: 2
Gerrit-Owner: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Magf -
magf@bitland.corp-partner.google.com
Gerrit-CC: Xiong Huang
xiong.huang@bitland.corp-partner.google.com
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Tue, 23 Jun 2020 06:45:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment