7 Apr
2020
7 Apr
'20
12:41 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40227 )
Change subject: nb/intel/i945: Use 'const' to set pci_devfn_t statically ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40227/1/src/northbridge/intel/i945/... File src/northbridge/intel/i945/early_init.c:
https://review.coreboot.org/c/coreboot/+/40227/1/src/northbridge/intel/i945/... PS1, Line 764: PCI_DEV(0, 0x01, 0) How about having these #defined somewhere?
--
To view, visit https://review.coreboot.org/c/coreboot/+/40227
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I879dd2fc61bc385486b506e2123f32629a67f518
Gerrit-Change-Number: 40227
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 06 Apr 2020 22:41:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment