11 Jan
2019
11 Jan
'19
7:55 p.m.
Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30724 )
Change subject: drivers/generic/adau7002: Add wakeup-delay-ms property ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/30724/1/src/drivers/generic/adau7002/adau700... File src/drivers/generic/adau7002/adau7002.c:
https://review.coreboot.org/#/c/30724/1/src/drivers/generic/adau7002/adau700... PS1, Line 32: dev->chip_info; if dev == NULL, you already crashed here...
If dev != NULL, is it possible for dev->config to be NULL? If not, no need for the "!config" check below.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30724
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32b18bf80fad5899ab4093a127dfd52d589bc365
Gerrit-Change-Number: 30724
Gerrit-PatchSet: 1
Gerrit-Owner: Akshu Agrawal akshu.agrawal@amd.com
Gerrit-Reviewer: Akshu Agrawal akshu.agrawal@amd.com
Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 11 Jan 2019 19:55:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment