Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30890 )
Change subject: autoport: Add support for Haswell-LynxPoint platform ......................................................................
Patch Set 10:
(2 comments)
Patch Set 10:
Patch Set 10:
Patch Set 10:
The commit fails to recognize the PCIe bridge on ASUS H81M-K: 8086:0c01
I quick-fixed it by adding: `RegisterPCI(0x8086, 0x0c01, GenericPCI{})` behind the loop for the VGA controller
Sorry for dumbtalk: Autoport still runs into an "Index out of range" error...
Um, why would you add a host bridge PCI ID to the VGA controller IDs?
https://review.coreboot.org/c/coreboot/+/30890/10/util/autoport/haswell.go File util/autoport/haswell.go:
https://review.coreboot.org/c/coreboot/+/30890/10/util/autoport/haswell.go@3... PS10, Line 35: "gfx.did": "{ 0x80000100, 0x80000240, 0x80000410, 0x80000410, 0x00000005 }", if you hardcode this, at least make it consistent with the gfx.ndid value
https://review.coreboot.org/c/coreboot/+/30890/10/util/autoport/lynxpoint.go File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/10/util/autoport/lynxpoint.go... PS10, Line 401: // the lid is open by default. Please use consistent comments in generated code