[coreboot-gerrit] [S] Change in coreboot[master]: sb,soc/amd,intel: Sync FADT entries visually

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Jeff Daly, Sean Rhodes, Jonathan Zhang, Johnny Lin, Christian Walter, Vanessa Eusebio, Arthur Heymans, Tim Chu.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74912 )

Change subject: sb,soc/amd,intel: Sync FADT entries visually
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1: 
git grep -h "fadt->x_" -- src/soc src/southbridge/ | sort | colrm 1 8 | uniq -c

1 fadt->x_firmware_ctl_h = 0;
      1 fadt->x_firmware_ctl_l = 0;	/* set to 0 if firmware_ctrl is used */
     16 fadt->x_gpe0_blk.access_size = ACPI_ACCESS_SIZE_BYTE_ACCESS;
     16 fadt->x_gpe0_blk.addrh = 0x0;
     16 fadt->x_gpe0_blk.addrl = fadt->gpe0_blk;
     16 fadt->x_gpe0_blk.bit_offset = 0;
     16 fadt->x_gpe0_blk.bit_width = fadt->gpe0_blk_len * 8;
     16 fadt->x_gpe0_blk.space_id = ACPI_ADDRESS_SPACE_IO;
      1 fadt->x_gpe1_blk.access_size = ACPI_ACCESS_SIZE_BYTE_ACCESS;
      1 fadt->x_gpe1_blk.addrh = 0x0;
      1 fadt->x_gpe1_blk.addrl = fadt->gpe1_blk;
      1 fadt->x_gpe1_blk.bit_offset = 0;
      1 fadt->x_gpe1_blk.bit_width = fadt->gpe1_blk_len * 8;
      1 fadt->x_gpe1_blk.space_id = ACPI_ADDRESS_SPACE_IO;
     15 fadt->x_pm1a_cnt_blk.access_size = ACPI_ACCESS_SIZE_WORD_ACCESS;
     15 fadt->x_pm1a_cnt_blk.addrh = 0x0;
     15 fadt->x_pm1a_cnt_blk.addrl = fadt->pm1a_cnt_blk;
     15 fadt->x_pm1a_cnt_blk.bit_offset = 0;
     15 fadt->x_pm1a_cnt_blk.bit_width = fadt->pm1_cnt_len * 8;
     15 fadt->x_pm1a_cnt_blk.space_id = ACPI_ADDRESS_SPACE_IO;
     15 fadt->x_pm1a_evt_blk.access_size = ACPI_ACCESS_SIZE_WORD_ACCESS;
     15 fadt->x_pm1a_evt_blk.addrh = 0x0;
     15 fadt->x_pm1a_evt_blk.addrl = fadt->pm1a_evt_blk;
     15 fadt->x_pm1a_evt_blk.bit_offset = 0;
     15 fadt->x_pm1a_evt_blk.bit_width = fadt->pm1_evt_len * 8;
     15 fadt->x_pm1a_evt_blk.space_id = ACPI_ADDRESS_SPACE_IO;
      1 fadt->x_pm1b_cnt_blk.space_id = ACPI_ADDRESS_SPACE_IO;
      1 fadt->x_pm1b_evt_blk.space_id = ACPI_ADDRESS_SPACE_IO;
     13 fadt->x_pm2_cnt_blk.access_size = ACPI_ACCESS_SIZE_BYTE_ACCESS;
     13 fadt->x_pm2_cnt_blk.addrh = 0x0;
     13 fadt->x_pm2_cnt_blk.addrl = fadt->pm2_cnt_blk;
     13 fadt->x_pm2_cnt_blk.bit_offset = 0;
     13 fadt->x_pm2_cnt_blk.bit_width = fadt->pm2_cnt_len * 8;
     13 fadt->x_pm2_cnt_blk.space_id = ACPI_ADDRESS_SPACE_IO;
     25 fadt->x_pm_tmr_blk.access_size = ACPI_ACCESS_SIZE_DWORD_ACCESS;
     25 fadt->x_pm_tmr_blk.addrh = 0x0;
     25 fadt->x_pm_tmr_blk.addrl = fadt->pm_tmr_blk;
     25 fadt->x_pm_tmr_blk.bit_offset = 0;
     25 fadt->x_pm_tmr_blk.bit_width = fadt->pm_tmr_len * 8;
     25 fadt->x_pm_tmr_blk.space_id = ACPI_ADDRESS_SPACE_IO;