Attention is currently required from: Angel Pons, Marvin Drees.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55895 )
Change subject: superio/nuvoton/nct5567d: Add NCT5567D support
......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS6:
only had a very brief look; mainly looked at the differences
File src/superio/nuvoton/nct5567d/superio.c:
https://review.coreboot.org/c/coreboot/+/55895/comment/3192fc01_82da2480
PS6, Line 62: 0x0ff8, },
{ NULL, NCT5567D_SP2, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, is missing here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55895
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a9fab2bb1fb7dc777b14e70a741e04636b967b8
Gerrit-Change-Number: 55895
Gerrit-PatchSet: 6
Gerrit-Owner: Marvin Drees
marvin.drees@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Marvin Drees
marvin.drees@9elements.com
Gerrit-Comment-Date: Wed, 07 Jul 2021 13:15:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment