[coreboot-gerrit] [M] Change in coreboot[main]: riscv/mb/qemu: fix DRAM probing

[Philipp Hug (Code Review)]

Attention is currently required from: Arthur Heymans, Felix Singer, Maximilian Brune, ron minnich, ron minnich.

Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36486?usp=email )

Change subject: riscv/mb/qemu: fix DRAM probing
......................................................................

Patch Set 17:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/36486/comment/7784be6e_741f5e79 :
PS15, Line 8:
> > `Possible unwrapped commit description (prefer a maximum 72 chars per line)` […]

Done

File src/arch/riscv/ramdetect.c:

https://review.coreboot.org/c/coreboot/+/36486/comment/a6a8087d_c12be64f :
PS15, Line 1: /*
            :  * This file is part of the coreboot project.
            :  *
            :  * SPDX-License-Identifier: GPL-2.0-or-later
            :  */
>

Done

https://review.coreboot.org/c/coreboot/+/36486/comment/7962c0cc_a7ef5fe1 :
PS15, Line 24: 	uint16_t ins = mprv_read_mxr_u16((uint16_t *)vaddr);
> Why use `mprv`? This should always be executed in machine mode.

dropped