Name of user not set #1003143 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48627 )
Change subject: commonlib/region: Add null parameters handling ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48627/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48627/1//COMMIT_MSG@9 PS1, Line 9: Prevent NULL-pointer dereference of child or parent root_device parameter.
I see you're adding multiple of these recently, but is there a particular reason for it in this case […]
After reviewing this patch I see your point. There is no need to add this check. I did it, because lib/fmap tests were failing after passing NULL as pointer to output structure. Would assert be better here?
With no NULL-check I will have to change lib/fmap tests and exclude this cases. I was thinking about leaving them as a comment with description.