Attention is currently required from: Arthur Heymans, Sridhar Siricilla, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59360 )
Change subject: soc/intel/alderlake, soc/common: Add method to determine the cpu type ......................................................................
Patch Set 7:
(4 comments)
File src/soc/intel/alderlake/cpu.c:
https://review.coreboot.org/c/coreboot/+/59360/comment/413bb621_4c1bda24 PS7, Line 30: ADL_MODEL_P = 0x9A, what about M?
File src/soc/intel/common/block/acpi/Kconfig:
https://review.coreboot.org/c/coreboot/+/59360/comment/c2aa3538_c45255f3 PS7, Line 50: nit: indent two spaces beyond `help` (i.e. one more space here)
File src/soc/intel/common/block/include/intelblocks/acpi.h:
https://review.coreboot.org/c/coreboot/+/59360/comment/1934139a_b8d50ccc PS7, Line 123: */ I would add more information about this here, e.g.
``` /* * This function determines the type (big or small) of the core that is executing * it and stores the information (in a thread-safe manner) in an array, which * can be consumed after MP initialization is finished. * * It requires the SoC to implement a function `get_soc_cpu_type()` (see below) * which will be called in a critical section to determine the type of the * executing core. */ ```
https://review.coreboot.org/c/coreboot/+/59360/comment/8ad2da4c_3c20a039 PS7, Line 126: /* Returns CPU type (big or small core) */ suggestion: ``` /* * This function returns the core type of the core that it is executing on. It * is designed to be called during MP initialization. If the SoC selects * SOC_INTEL_COMMON_BLOCK_ACPI_CPU_HYBRID, then this function must be * implemented, and will be called from set_cpu_type(). */ ```