Attention is currently required from: Arthur Heymans, Sridhar Siricilla, Patrick Rudolph.
4 comments:
File src/soc/intel/alderlake/cpu.c:
Patch Set #7, Line 30: ADL_MODEL_P = 0x9A,
what about M?
File src/soc/intel/common/block/acpi/Kconfig:
nit: indent two spaces beyond `help` (i.e. one more space here)
File src/soc/intel/common/block/include/intelblocks/acpi.h:
I would add more information about this here, e.g.
```
/*
* This function determines the type (big or small) of the core that is executing
* it and stores the information (in a thread-safe manner) in an array, which
* can be consumed after MP initialization is finished.
*
* It requires the SoC to implement a function `get_soc_cpu_type()` (see below)
* which will be called in a critical section to determine the type of the
* executing core.
*/
```
Patch Set #7, Line 126: /* Returns CPU type (big or small core) */
suggestion:
```
/*
* This function returns the core type of the core that it is executing on. It
* is designed to be called during MP initialization. If the SoC selects
* SOC_INTEL_COMMON_BLOCK_ACPI_CPU_HYBRID, then this function must be
* implemented, and will be called from set_cpu_type().
*/
```
To view, visit change 59360. To unsubscribe, or for help writing mail filters, visit settings.