12 Oct
2020
12 Oct
'20
8:21 a.m.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45396 )
Change subject: soc/mediatek/mt8192: Refactor USB code among similar SoCs ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45396/1/src/soc/mediatek/mt8192/usb... File src/soc/mediatek/mt8192/usb.c:
https://review.coreboot.org/c/coreboot/+/45396/1/src/soc/mediatek/mt8192/usb... PS1, Line 12: setbits32
set or clrset? […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/45396
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb4cc304654b5fb7cf20b96ab83a22663bfeab63
Gerrit-Change-Number: 45396
Gerrit-PatchSet: 6
Gerrit-Owner: CK HU ck.hu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Yidi Lin yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 12 Oct 2020 06:21:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Gerrit-MessageType: comment