Philip Chen has posted comments on this change. ( https://review.coreboot.org/19489 )
Change subject: google/gru: skip usbphy1 setup for Scarlet ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/19489/3//COMMIT_MSG Commit Message:
PS3, Line 2: philipchen
This should say "Philip Chen". Can you double-check your git config?
Fixed my git config.
PS3, Line 7: scarlet/gru
This would be better as "google/gru: ", probably, then you can keep the "Sc
Done
Line 8:
Please mention the reason for skipping the setup.
Done
https://review.coreboot.org/#/c/19489/3/src/mainboard/google/gru/mainboard.c File src/mainboard/google/gru/mainboard.c:
PS3, Line 309: {
nit: can remove braces
Done