Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45643 )
Change subject: mb/google/volteer: Disable HybridStorageMode for volteer baseboard
......................................................................
Patch Set 4:
(1 comment)
Patch Set 3:
In order not to break any devices with hybrid storage, I think you'll need to add `register "HybridStorageMode" = "1"` to volteer & volteer2 overridetree.cb files
https://review.coreboot.org/c/coreboot/+/45643/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45643/4/src/mainboard/google/voltee...
PS4, Line 50: register "HybridStorageMode" = "1"
Won't this still break volteer SKUs that don't have octane?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45643
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54fc78e3f888d4f2a02ba0ad6b9aef33eb872a9c
Gerrit-Change-Number: 45643
Gerrit-PatchSet: 4
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 09 Oct 2020 18:16:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment