Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36553 )
Change subject: soc/intel/tigerlake/acpi: Copy acpi directory from icelake ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36553/4/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/scs.asl:
https://review.coreboot.org/c/coreboot/+/36553/4/src/soc/intel/tigerlake/acp... PS4, Line 26: ^PCRA use absolute path?
https://review.coreboot.org/c/coreboot/+/36553/4/src/soc/intel/tigerlake/acp... PS4, Line 56: ^^SCSC use absolute path?
https://review.coreboot.org/c/coreboot/+/36553/4/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/serialio.asl:
https://review.coreboot.org/c/coreboot/+/36553/4/src/soc/intel/tigerlake/acp... PS4, Line 17: : Device (I2C0) : { : Name (_ADR, 0x00150000) : Name (_DDN, "Serial IO I2C Controller 0") : } : : Device (I2C1) : { : Name (_ADR, 0x00150001) : Name (_DDN, "Serial IO I2C Controller 1") : } : : Device (I2C2) : { : Name (_ADR, 0x00150002) : Name (_DDN, "Serial IO I2C Controller 2") : } : : Device (I2C3) : { : Name (_ADR, 0x00150003) : Name (_DDN, "Serial IO I2C Controller 3") : } : : Device (I2C4) : { : Name (_ADR, 0x00190000) : Name (_DDN, "Serial IO I2C Controller 4") : } : : Device (I2C5) : { : Name (_ADR, 0x00190001) : Name (_DDN, "Serial IO I2C Controller 5") : } : : Device (SPI0) : { : Name (_ADR, 0x001e0002) : Name (_DDN, "Serial IO SPI Controller 0") : } : : Device (SPI1) : { : Name (_ADR, 0x001e0003) : Name (_DDN, "Serial IO SPI Controller 1") : } : : Device (SPI2) : { : Name (_ADR, 0x00120006) : Name (_DDN, "Serial IO SPI Controller 2") : } : : Device (UAR0) : { : Name (_ADR, 0x001e0000) : Name (_DDN, "Serial IO UART Controller 0") : } : : Device (UAR1) : { : Name (_ADR, 0x001e0001) : Name (_DDN, "Serial IO UART Controller 1") : } : : Device (UAR2) : { : Name (_ADR, 0x00190002) : Name (_DDN, "Serial IO UART Controller 2") Why is this needed?
https://review.coreboot.org/c/coreboot/+/36553/4/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/smbus.asl:
https://review.coreboot.org/c/coreboot/+/36553/4/src/soc/intel/tigerlake/acp... PS4, Line 18: Device (SBUS) : { : Name (_ADR, 0x001f0004) : } Why is this needed? PCI devices don't need this for enumeration?