Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45451 )
Change subject: nb/intel/gm45: Introduce memmap.h ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45451/3/src/northbridge/intel/gm45/... File src/northbridge/intel/gm45/memmap.h:
https://review.coreboot.org/c/coreboot/+/45451/3/src/northbridge/intel/gm45/... PS3, Line 10:
It answers why, and also explains that this line wasn't always `additional`. […]
I guess I just want to talk to people about such things in case they are intentional. Don't remember if I wanted the line removed. If so, I'd have left the comment unresolved, but I can't recall if I did... Generally, multiple empty lines in a row are frowned upon in coreboot, but I don't like to tell people to remove them without having talked about it *shrug*