[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Use PSP Sx command only for S3

[Marshall Dawson (Code Review)]

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43038 )

Change subject: soc/amd/picasso: Use PSP Sx command only for S3
......................................................................

soc/amd/picasso: Use PSP Sx command only for S3

Skip sending MboxBiosCmdSxInfo for sleep states other than S3.  The
PSP only acts on S3 and ignores all others.  As a result, the command
register is not cleared upon return and coreboot reports a timeout.

BUG=b:153622879
TEST=Use halt from command line, verify command skipped.

Signed-off-by: Marshall Dawson 
Change-Id: Ic47b8507e29e4c53898e88fb46e532b71df87d07
---
M src/soc/amd/picasso/smihandler.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/43038/1

diff --git a/src/soc/amd/picasso/smihandler.c b/src/soc/amd/picasso/smihandler.c
index 992dc2b..7e762a9 100644
--- a/src/soc/amd/picasso/smihandler.c
+++ b/src/soc/amd/picasso/smihandler.c
@@ -208,7 +208,8 @@
    					reg32);
    	} /* if (CONFIG(ELOG_GSMI)) */

-		psp_notify_sx_info(slp_typ);
+		if (slp_typ == ACPI_S3)
+			psp_notify_sx_info(ACPI_S3);

smu_sx_entry(); /* Leave SlpTypeEn clear, SMU will set */
    	printk(BIOS_ERR, "Error: System did not go to sleep\n");