Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41418 )
Change subject: memrange: Add helper for stealing memory from the last range in the list ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41418/4/src/lib/memrange.c File src/lib/memrange.c:
https://review.coreboot.org/c/coreboot/+/41418/4/src/lib/memrange.c@406 PS4, Line 406: base = ALIGN_UP(r->begin, POWER_OF_2(align)); : end = base + size - 1; : : if (end > r->end) : continue; : In case we have a single big memrange that goes across the start of the memory I/O hole, we would have to align things to the end here in case of STEAL_LAST_AVAILABLE. Didn't look at logs if this is the case, but in theory this might still cause trouble.