Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47598 )
Change subject: arch/x86: Remove ID_SECTION_OFFSET ......................................................................
Patch Set 2:
Patch Set 2:
See related CB:40376 CB:40377 and CB:47602.
A decision should be made if .id section can be dropped and compatibility with old flashrom (and FILO) builds sacrified with some schedule, 2022 at earliest perhaps. I think post-processing approach would allow removal of id.S independently of that.
In CB:40377 it looked like we could settle for a simple file in CBFS instead. As that's simple enough to do even out-of-tree, I see no problem to remove the section, but also not much of a reason to.
My motivation was to wipe out arch/x/id.S files that only contain strings and offsets. Maybe link lib/version.c to separate .text._ver_ such that for hexdumps strings would conveniently appear at start or end of binary?
When I talked about .id section I referred to the one in x86 bootblock. Keeping the offsets at 0xffffff70 but moving the strings would be my suggestion for flashrom compatibility.
I don't understand the purpose of .id for !ENV_X86 case in lib/program.ld. The version strings will appear at arbitrary location near start of binary, Are the offsets used for anything? Is the purpose to just force the strings to be present in binary even with decompressor/bootblock console disabled? Some of those builds are extremely tight fits already.