Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49049 )
Change subject: drivers/vpd: Add VPD region to default FMAP when selected
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/49049/1/src/drivers/vpd/Kconfig
File src/drivers/vpd/Kconfig:
https://review.coreboot.org/c/coreboot/+/49049/1/src/drivers/vpd/Kconfig@12
PS1, Line 12: default "RO_VPD"
is it always read-only? iow would writable vpd make any sense? if not, why make the name configurable?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49049
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9e3c7cf11a6337a43223a6037632a4d9c84d988
Gerrit-Change-Number: 49049
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 Jan 2021 21:00:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment