Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31112 )
Change subject: soc/intel/common/rtc: Enable RTC if common code RTC
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Thanks. We should remove the redundant selects from APL/SKL, see CB:31113.
https://review.coreboot.org/#/c/31112/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31112/1//COMMIT_MSG@9
PS1, Line 9: Intel RTC common code driver need to turn on RTC itself.
Maybe mention that this adds RTC for CNL/ICL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31112
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c8c5cf9e6f7f338b1f2f784c04254649d257536
Gerrit-Change-Number: 31112
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 27 Jan 2019 10:47:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment