[coreboot-gerrit] Change in coreboot[master]: [RFC] pci_mmio_cfg: Move guard around pci_s_* functions to x86

[Nico Huber (Code Review)]

Attention is currently required from: Shelley Chen, Furquan Shaikh, Tim Wawrzynczak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58331 )

Change subject: [RFC] pci_mmio_cfg: Move guard around pci_s_* functions to x86
......................................................................

Patch Set 2:

(1 comment)

File src/arch/x86/include/arch/pci_ops.h:

https://review.coreboot.org/c/coreboot/+/58331/comment/6f45af7b_b89cd517 
PS2, Line 7: MMCONF_SUPPORT
> > I don't think we need a Kconfig option for mmio
>
> ops in general.
>
> Sorry, I'm a little confused by this statement.  Just to clarify, do you imagine:
>
> MMCONF_SUPPORT : enable mmio ops (mostly non-x86 platforms)
> MMCONF_ECAM_SUPPORT: enable mmio ops using ECAM (mostly x86 platforms)
> NO_MMCONF_SUPPORT: no mmio ops support (revert to io ops)

No, I imagine:

platform includes pci_mmio_cfg.h: enable mmio ops
MMCONF_ECAM_SUPPORT: enable mmio ops using ECAM
(optionally NO_MMCONF_ECAM_SUPPORT: just to easily disable MMCONF_ECAM_SUPPORT)

Less options is better, IMO.