Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40335 )
Change subject: soc/intel/common/block/acpi: Add provision for multiple PCI segments
......................................................................
Patch Set 5:
Does ICL really have multiple PCI segments?
If a platform supports more than 256 buses, then it should support multi-segment.
It aligns with the below description in the EDS.
I guess that's a no (for ICL).
TGL as you know supports 2 segments,
Nope, I didn't know that.
1 for TBT and 1 for the rest of the devices which adds up to a total of 512 buses.
Thanks for mentioning this. Even if it is not your reason
for this change, please put this information into the commit
message. It makes a huge difference: without it, your changes
look like added complexity for naught; with it, there is a
reason and reviewers can do their job.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40335
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90660c5cfd8af5bb40e36bb409e534541c786cae
Gerrit-Change-Number: 40335
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 25 Apr 2020 10:55:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment