Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80690?usp=email )
Change subject: soc/intel/braswell/gpio_support: drop unused get_gpio ......................................................................
soc/intel/braswell/gpio_support: drop unused get_gpio
The get_gpio function in this file is both unused and it shouldn't use a signed int to pass in the MMIO base address and offset.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I3b08bad040ad175b37175ef21d0a0a29525c4478 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80690 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@amd.corp-partner.google.com --- M src/soc/intel/braswell/gpio_support.c M src/soc/intel/braswell/include/soc/gpio.h 2 files changed, 0 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/soc/intel/braswell/gpio_support.c b/src/soc/intel/braswell/gpio_support.c index 0a2e001..34464af 100644 --- a/src/soc/intel/braswell/gpio_support.c +++ b/src/soc/intel/braswell/gpio_support.c @@ -143,8 +143,3 @@
return pad_value & PAD_RX_BIT; } - -int get_gpio(int community_base, int pad0_offset) -{ - return (read32p(community_base + pad0_offset)) & PAD_RX_BIT; -} diff --git a/src/soc/intel/braswell/include/soc/gpio.h b/src/soc/intel/braswell/include/soc/gpio.h index 2a01b2d..d4bfb89 100644 --- a/src/soc/intel/braswell/include/soc/gpio.h +++ b/src/soc/intel/braswell/include/soc/gpio.h @@ -466,7 +466,6 @@
typedef int gpio_t;
-int get_gpio(int community_base, int pad0_offset); uint16_t gpio_family_number(uint8_t community, uint8_t pad); uint32_t *gpio_pad_config_reg(uint8_t community, uint8_t pad);