HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39178 )
Change subject: sb/amd: Move smbus to common place ......................................................................
Patch Set 10:
(4 comments)
Thx
https://review.coreboot.org/c/coreboot/+/39178/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39178/10//COMMIT_MSG@7 PS10, Line 7: sb/amd: Move smbus to common place
Move SMBus code to common place
Done Thx
https://review.coreboot.org/c/coreboot/+/39178/10/src/southbridge/amd/cimx/s... File src/southbridge/amd/cimx/sb800/smbus.h:
https://review.coreboot.org/c/coreboot/+/39178/10/src/southbridge/amd/cimx/s... PS10, Line 19: #define SMBUS_IO_BASE SMBUS0_BASE_ADDRESS
This isn't being kept. […]
if I'm not wrong, SMBUS_IO_BASE is not used.
https://review.coreboot.org/c/coreboot/+/39178/10/src/southbridge/amd/cimx/s... File src/southbridge/amd/cimx/sb800/smbus.c:
https://review.coreboot.org/c/coreboot/+/39178/10/src/southbridge/amd/cimx/s... PS10, Line 66: printk(BIOS_DEBUG, "SB800 - Smbus.c - do_smbus_recv_byte - smbus not ready.\n");
Do we want to keep these printk() calls? Maybe as a debug option?
Ack
https://review.coreboot.org/c/coreboot/+/39178/10/src/vendorcode/amd/cimx/sb... File src/vendorcode/amd/cimx/sb800/SB800.h:
https://review.coreboot.org/c/coreboot/+/39178/10/src/vendorcode/amd/cimx/sb... PS10, Line 709: AX_INDXP 1
In the locations that were kept, this is defined as 2. […]
looks like only sb800 have AX_INDXP defined as 1. thought it was a typo. Fixed now.