Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39690 )
Change subject: mb/ocp/tiogapass: Configure IPMI FRB2 watchdog timer via VPD variables in romstage
......................................................................
Patch Set 28: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/39690/28//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39690/28//COMMIT_MSG@7
PS28, Line 7: variables in romstage
nit: I'd drop this part from the commit message and mention romstage in the commit message body
https://review.coreboot.org/c/coreboot/+/39690/28//COMMIT_MSG@14
PS28, Line 14: Added
Add
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39690
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53b69c3c5d22c022130fd812ef26097898d913d0
Gerrit-Change-Number: 39690
Gerrit-PatchSet: 28
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 03 Jul 2020 19:54:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment