David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35884 )
Change subject: soc/intel/Kconfig: Move MMCONF_BASE_ADDRESS out of a common place
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35884/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35884/1//COMMIT_MSG@12
PS1, Line 12: wrong
I agree but still wonder: With a change like this, that has no technical […]
Agreed, SOC specific FSP-T will set a value for this, and no guarantee that all SOCs will use the same value.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35884
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcfea1718cc36ae16b491604786c26c6ed320f06
Gerrit-Change-Number: 35884
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Thu, 31 Oct 2019 15:58:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment