[coreboot-gerrit] [S] Change in coreboot[main]: lib: Refactor bmp_load_logo() implementation

[Julius Werner (Code Review)]

Attention is currently required from: Andrey Petrov, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Ronak Kanabar, Sean Rhodes, Subrata Banik.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81618?usp=email )

Change subject: lib: Refactor bmp_load_logo() implementation
......................................................................

Patch Set 3:

(2 comments)

File src/drivers/intel/fsp1_1/ramstage.c:

https://review.coreboot.org/c/coreboot/+/81618/comment/422d7bee_f37735d7 :
PS3, Line 81: uint32_t
I don't think this would compile for 64-bit. Better make this a cast to `uintptr_t`. (You can leave the narrowing conversion from there to `uint32_t` implicit or add another cast in front of that.)

Same issue at most other call sites.

File src/drivers/intel/fsp2_0/fsp_gop_blt.c:

https://review.coreboot.org/c/coreboot/+/81618/comment/c9e7633a_929f3651 :
PS3, Line 241: logo_size_t
`_t` is usually a suffix for types, not variable identifiers. Why not just change `logo_ptr_size` to a `size_t`?