Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )
Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL
......................................................................
Patch Set 18: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/48286/18//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48286/18//COMMIT_MSG@15
PS18, Line 15: 32:33
We only reset bits `[1:0]` in teardown
That's a good point. Teardown path does not take into account COS_MAPPED_TO_MSB.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48286
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iabf7f387fb5887aca10158788599452c3f2df7e8
Gerrit-Change-Number: 48286
Gerrit-PatchSet: 18
Gerrit-Owner: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 14 Dec 2020 21:05:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment