Attention is currently required from: Saurabh Mishra, Ronak Kanabar, Felix Held.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67167 )
Change subject: vc/intel/fsp: Update ADL N FSP headers from v3267.01 to v3301.00
......................................................................
Patch Set 4:
(1 comment)
File src/vendorcode/intel/fsp/fsp2_0/alderlake_n/FspsUpd.h:
https://review.coreboot.org/c/coreboot/+/67167/comment/18cf64f7_eeccf377
PS4, Line 3898: UINT8 Reserved57;
Maybe in some future commit, these could be renamed to just match their offsets so that they don't need to be renumbered every time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67167
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b921e2aa467593a1c764fc554e2e83e8bb526e8
Gerrit-Change-Number: 67167
Gerrit-PatchSet: 4
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.corp-partner.google.com
Gerrit-CC: Haribalaraman Ramasubramanian
haribalaraman.r@intel.corp-partner.google.com
Gerrit-CC: Jesper Lin
jesper_lin@wistron.corp-partner.google.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.corp-partner.google.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Sowmya V
v.sowmya@intel.corp-partner.google.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 04 Sep 2022 16:08:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment