Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33859 )
Change subject: Kconfig: Enable RAMPAYLOAD for x86
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/33859/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33859/3//COMMIT_MSG@10
PS3, Line 10: of HAVE_RAMPAYLOAD kconfig from mainboard for x86 platform.
I don't think those equivalent for comparison purposes. In this CL you are changing the whole boot flow for a mainboard once HAVE is selected. It would require someone to deselect that option if they didn't want the behavior. But maybe it's fine.
I was thinking HAVE_RAMPAYLOAD as a "has support" thing, but it's really more of a 'there is a rampayload'. So I guess it's fine?
yes, i also think so
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33859
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40308bbf970a0dbe5f7e2086ed8a7a70c2a3a32c
Gerrit-Change-Number: 33859
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 01 Jul 2019 15:01:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment