Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40262 )
Change subject: soc/intel/tigerlake: Configure RP setting
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40262/3/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/40262/3/src/soc/intel/tigerlake/fsp...
PS3, Line 128: params->PcieRpLtrEnable[i] = !config->PcieRpLtrDisable[i];
If that is the case, I would recommend skipping setting of this UPD completely. […]
We still need to set it as FSP default value is LTR disabled but we want to enable LTR by default(without adding in devicetree) for enabling ASPM fully.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40262
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I668f2e5fea15019a9e5ae06fb4d55fa2aea69e8a
Gerrit-Change-Number: 40262
Gerrit-PatchSet: 4
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alex Levin
levinale@google.com
Gerrit-Comment-Date: Wed, 08 Apr 2020 05:39:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Comment-In-Reply-To: Alex Levin
levinale@google.com
Gerrit-MessageType: comment