Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31592 )
Change subject: ACPI: Enum only used ACPI tables ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/31592/4/src/arch/x86/include/arch/acpi.h File src/arch/x86/include/arch/acpi.h:
https://review.coreboot.org/#/c/31592/4/src/arch/x86/include/arch/acpi.h@80 PS4, Line 80: /* ACPI Tables defined/reserved by ACPI 6.3 */ Drop/update this?
https://review.coreboot.org/#/c/31592/4/src/arch/x86/include/arch/acpi.h@95 PS4, Line 95: */ Maybe get rid of the commented table names? Otherwise these comments could get out of sync, or worse, some- body could try to keep them sync'ed.