Attention is currently required from: Francois Toguo Fotso, Tim Wawrzynczak, Patrick Rudolph.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55054 )
Change subject: acpi: rework BERT SSDT generation logic
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/acpi/acpi_bert.c:
https://review.coreboot.org/c/coreboot/+/55054/comment/7b421a81_31159e75
PS1, Line 13: SOC_INTEL_CRASHLOG
Right now, this is defined in soc/tigerlake and soc/alderlake, not soc/intel/common/block, although […]
iirc an undefined Kconfig symbol evaluates as false, so this does work as expected even though it probably isn't how things are supposed to be, so it would probably be a good idea if you move that.
I just moved this block of code and turned it into a static function
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55054
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a281f5f636010ba3b2e7e097e9cf53683022aea
Gerrit-Change-Number: 55054
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 01 Jun 2021 19:50:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment