Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47396 )
Change subject: soc/intel/tigerlake: Check TBT & TCSS ports for wake events ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47396/3/src/soc/intel/tigerlake/elo... File src/soc/intel/tigerlake/elog.c:
https://review.coreboot.org/c/coreboot/+/47396/3/src/soc/intel/tigerlake/elo... PS3, Line 86: SA_DEVFN_TCSS_XDCI
Was SA_DEVFN_TCSS_XHCI intentionally skipped here? I think with the suggestion that I made on previous CL, it would make sense to not include ELOG_WAKE_SOURCE_PME_TCSS_XHCI or PCH_DEVFN_XHCI in this table and let `xhci_update_wake_event` handle it.
Agreed.
https://review.coreboot.org/c/coreboot/+/47396/3/src/soc/intel/tigerlake/elo... PS3, Line 125: dev_found =
You lose information about `dev_found` if it was already set to true before this.
Ooh true, also line 120, those will have to be OR