Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31536 )
Change subject: soc/intel/cannonlake: Set correct serirq mode based on SERIRQ_CONTINUOUS_MODE
......................................................................
Patch Set 3:
Patch Set 2: Code-Review+1
(1 comment)
Thanks for the fix. I wouldn't mind merging it in this
state, though maybe see if we can settle on the Kconfig
vs `chip.h` thing, first.
NB. There may be more unset UPDs related to serial irqs.
Maybe we should set them all at once.
I changed it to be done in chip.h
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31536
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ad4f5a6c7391fc6e813ec1306c708f449a69f59
Gerrit-Change-Number: 31536
Gerrit-PatchSet: 3
Gerrit-Owner: Jeremy Soller
jackpot51@gmail.com
Gerrit-Reviewer: Jeremy Soller
jackpot51@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Feb 2019 16:53:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment