Attention is currently required from: Hung-Te Lin, Philipp Hug, Jakub Czapiga, Matt DeVillier, Angel Pons, Julius Werner, Andrey Petrov, ron minnich, Felix Held.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69078 )
Change subject: cbmem_top_chipset: Change the return value to uintptr_t
......................................................................
Patch Set 4:
(4 comments)
Patchset:
PS4:
Thank you.
File src/northbridge/intel/x4x/memmap.c:
https://review.coreboot.org/c/coreboot/+/69078/comment/091e3b03_e97ca0a1
PS1, Line 76: uintptr_t top_of_ram = ALIGN_DOWN(northbridge_get_tseg_base(), 4*MiB);
: return top_of_ram;
+1, there are other occurrences in other Intel platforms. Could be done in a follow-up.
Done
File src/soc/nvidia/tegra124/cbmem.c:
https://review.coreboot.org/c/coreboot/+/69078/comment/082426b9_d91d2a13
PS1, Line 9: return ((sdram_max_addressable_mb() - FB_SIZE_MB) << 20UL);
nit: Outer set of parentheses is now unnecessary
Done
File src/soc/sifive/fu540/cbmem.c:
https://review.coreboot.org/c/coreboot/+/69078/comment/d9a9261f_5e5eea76
PS1, Line 11: return MIN((uintptr_t)_dram + sdram_size_mb() * MiB,
: FU540_MAXDRAM);
nit: Can it fit in one line?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69078
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93645ef5dd270905ce421e68e342aff4c331eae6
Gerrit-Change-Number: 69078
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 02 Nov 2022 13:55:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment