Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34514 )
Change subject: mb/google/hatch: Enable chipset_lockdown coreboot config for hatch
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34514/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34514/1//COMMIT_MSG@9
PS1, Line 9: lockdown configuration
you are right Furquan. […]
Furquan,
Looks like except "SpiFlashCfgLockDown" UPD, we have others available in CML. Today FSP is unconditionally locking down DLOCK and FLOCK inside FSP.
tconfig->PchLockDownGlobalSmi = config->LockDownConfigGlobalSmi;
tconfig->PchLockDownRtcLock = config->LockDownConfigRtcLock;
if (get_lockdown_config() == CHIPSET_LOCKDOWN_COREBOOT) {
tconfig->PchLockDownBiosInterface = 0;
params->PchLockDownBiosLock = 0;
params->PchLockDownSpiEiss = 0;
}
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34514
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6dc90156dc76fde490b25cf833da3cf80f664f2
Gerrit-Change-Number: 34514
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 23 Jul 2019 15:23:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment