build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31046 )
Change subject: mediatek/mt8183: Add RTC support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31046/1/src/soc/mediatek/mt8183/rtc.c File src/soc/mediatek/mt8183/rtc.c:
https://review.coreboot.org/#/c/31046/1/src/soc/mediatek/mt8183/rtc.c@156 PS1, Line 156: rtc_xosc_write((osc32con & ~RTC_EMBCK_SRC_SEL) | RTC_XOSC32_ENB | RTC_REG_XOSC32_ENB); line over 80 characters
https://review.coreboot.org/#/c/31046/1/src/soc/mediatek/mt8183/rtc.c@253 PS1, Line 253: printk(BIOS_INFO, "[RTC] %s:%d timeout\n", __func__,__LINE__); space required after that ',' (ctx:VxV)