14 Apr
2022
14 Apr
'22
3 p.m.
Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Eric Lai. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62789 )
Change subject: ec/google/chromeec: add fan speed rpm control ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62789/comment/22cfd2f7_78d061d9 PS2, Line 10:
Where is CFSP documented?
Added doc number under commit message.
https://review.coreboot.org/c/coreboot/+/62789/comment/a640e95b_0a33318d PS2, Line 13: TEST=Built and booted on ADL-P based Brya system
And then? How to verified the fan speed?
Verified the fan speed by checking the sysfs value.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62789
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb1646b1fb1659fd853ece97d97bb9dee2a3f57e
Gerrit-Change-Number: 62789
Gerrit-PatchSet: 3
Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 14 Apr 2022 13:00:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Gerrit-MessageType: comment