Attention is currently required from: Julius Werner, Tim Wawrzynczak.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59877 )
Change subject: cbfstool: Fix offset calculation for aligned files
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/59877/comment/49cddeaa_9e0c39c3
PS2, Line 1085: *offset;
I don't really understand this x86-specific address space stuff well, so I hope someone can correct […]
As far as I understand too, there are only the 2 address spaces at play here, host and flash and basically yeah the host address space is for convenience when dealing with addresses where what matters in the end is the resulting memory-mapped address on x86.
and I agree that this looks like it is preserving existing behavior.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59877
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia49a585988f7a74944a6630b77b3ebd79b3a9897
Gerrit-Change-Number: 59877
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Mon, 06 Dec 2021 22:44:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment